Pin monarch lib to a commit SHA and document the fork landscape#9
Conversation
- bump monarchmoneycommunity pin from moving `rev=main` to the fork's `dev` HEAD SHA (befdadc) — gains the `reviewed` param on update_transaction and makes builds reproducible - add an "Upstream Library & Fork Landscape" section to CLAUDE.md covering the parent/community/enhanced forks, our pin, unused capabilities, and a how-to-keep-current checklist - fix the stale dependency line that still referenced `monarchmoney ≥0.1.15`
|
Claude finished @jamiew's task in 1m 0s —— View job Overall: Approve. Clean dependency hygiene, zero functional risk, and genuinely useful documentation that prevents this context from getting lost again. View full review
|
| Area | Verdict |
|---|---|
| Dependency pin | ✅ Correct, reproducible |
| Lock file | ✅ Consistent with pin |
| Documentation | ✅ High-quality, actionable |
Test coverage for reviewed kwarg |
bumps our monarch client pin and writes down what i learned analyzing the upstream fork landscape, since this library is a fork-of-a-fork and that context kept getting lost.
monarchmoneycommunitypin from the movingrev=mainto the fork'sdevHEAD commit (befdadc) — reproducible builds, plus it picks up the newreviewedparam onupdate_transactionmonarchmoney ≥0.1.15to test:
uv sync && uv run python scripts/ci.py→ all greenupdate_transactionnow accepts areviewedkwarg